https://bugzilla.redhat.com/show_bug.cgi?id=1332607
--- Comment #6 from Jerry James <[email protected]> --- (In reply to James Hogarth from comment #5) > ===== Issues ===== > > * Unowned created directory /etc/logrotate.d Fixed. > * Missing requires on logrotate > - Since it has a logrotate configuration it needs a Requires on logrotate I don't think so. Of the 20 packages that dropped files into /etc/logrotate.d on my machine, only 2 of them (rsyslog and rpmorphan) depend on logrotate. The other packages drop config files in there for logrotate to use if it is installed, but function without it being installed. I believe this package falls into that category. Logrotate is not necessary for proper functioning. > * Documentation in /usr (%{_gap_dir}) > - This is standard for GAP packages as it's used for runtime online docs > * Deletes the user it creates > - userdel in %postun is not permitted: > https://fedoraproject.org/wiki/Packaging:UsersAndGroups#Allocation_Strategies I was not aware of that wiki page. Thanks for pointing it out. I have removed the offending command. New URLs: Spec URL: https://jjames.fedorapeople.org/gap-pkg-scscp/gap-pkg-scscp.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-scscp/gap-pkg-scscp-2.1.4-3.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
