https://bugzilla.redhat.com/show_bug.cgi?id=1358959
Igor Gnatenko <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Igor Gnatenko <[email protected]> --- > Source0: > https://github.com/jonasdn/nsntrace/releases/download/v1/nsntrace-1.tar.gz Source0: %{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz > make %{?_smp_flags} > %make_build those are same, use only one (second is better) > %setup -q -n %{name}-%{version} %setup and %autosetup automatically does "-n %{name}-%{version}", so just replace with "%autosetup -p0" and drop "%patch0 -p0". > rm -rf $RPM_BUILD_ROOT not needed since EL5(?) > BuildRequires: automake > BuildRequires: autoconf you don't do autoreconf nor something like this, so you don't need those BRs > %{_bindir}/* Personally I don't like such things, it's too soft. Do something like %{_bindir}/%{name} * Missing BuildRequires: gcc * Check if dependencies used by pkg-config from autotools, if yes, replace dependencies with pkgconfig(MODULE) This is just some short review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
