https://bugzilla.redhat.com/show_bug.cgi?id=1354545
--- Comment #8 from Jun Aruga <[email protected]> --- Okay, I am APPROVED. (In reply to Vít Ondruch from comment #7) > (In reply to Jun Aruga from comment #6) > > Hi, > > I reviewed the files. > > > > # Highlight > > > > I have just one thing to ask you. > > > > 1. These 2 files have the comment related on the copyright. Is there > > something to do in the RPM spec file for these files? > > > > ./lib/action_cable/connection/client_socket.rb > > ./lib/action_cable/connection/stream.rb > > > > # This class is heavily based on faye-websocket-ruby > > #--- > > # Copyright (c) 2010-2015 James Coglan > > I don't see any problem with this. faye-websocket-ruby is MIT licensed [1], > so you can do almost everything with the code. > > > Could you please approve the package if you have no other concerns? Thank > you. > > > > [1] https://github.com/faye/faye-websocket-ruby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
