https://bugzilla.redhat.com/show_bug.cgi?id=1346038



--- Comment #18 from David Lehman <[email protected]> ---
(In reply to Douglas Schilling Landgraf from comment #17)
> ERROR: 'Cannot find spec file in srpm' (logs in
> /home/fedora/.cache/fedora-review.log)
> 
> This is caused because your spec file is called python-blivet.spec not
> python-blivet1.spec. 

Yes, I have to fix this.

> 
> I have other question now, I see you are package maint. of python-blivet
> package, why not use the current spec to create a subpackage of python2 and
> python3 ? No need to create a new package/review "python-blivet1", just add
> the new subpackages and rebuild it, like:
> 
> python2-blivet
> python3-blivet 

The python-blivet-2.x codebase is not python2-compatible. That is why this
compatibility package is being introduced. We cannot use python2-blivet-1.x
because the translations would collide with those from python3-blivet-2.x.

> Finally, recommend you to use global instead of define in your python-blivet:

Will do.


New package coming soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to