https://bugzilla.redhat.com/show_bug.cgi?id=1352997
Zbigniew Jędrzejewski-Szmek <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> --- In all three packages, it would be better to add some kind of tests in %check. For example in this package you could add a simple package in the old format and convert it in %check to see that the executables work as expected. gns3-net-converter.noarch: W: incoherent-version-in-changelog 1.5.0-1 ['1.3.0-1.fc24', '1.3.0-1'] "-n %{name}-%{version}" is the default, it can be removed. %description should end in a dot. + package name is OK + latest version + python packaging template is used + rpmlint is happy (module the warning above) + no scriptlets present or necessary + %description is legible You package does not have any python Provides. This means that other packages cannot depend on the gns3converter python module. I don't know if that would actually be possible, that is if the module can be used externally. I guess it's OK to leave things as they are for now. Package is APPROVED. Please fix the small issues listed at the top, and consider adding %check. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
