https://bugzilla.redhat.com/show_bug.cgi?id=1344101
--- Comment #7 from František Dvořák <val...@civ.zcu.cz> ---
(In reply to Jun Aruga from comment #6)
> Hi, František Dvořák
>
> I reviewed it. I want to ask you below points.
>
> # Summary
>
> ## 1.
>
> > %if 0%{?rhel} && 0%{?rhel} <= 7
> > Requires: ruby(rubygems)
> > Provides: rubygem(%{gem_name}) = %{version}
> > %endif
>
> Do you want to use this pacakge for rhel too now?
> Actually I am not confident that this 2 lines are correct for condition rhel
> <= 7. I can agree with your style if you are confident for the 2 lines.
>
It is true these lines could be removed.
These lines were always needed for EPEL7 (and for F20, which is not needed to
check anymore), but it it true I'm not going to package it for EPEL7 right now.
I'm interested in EPEL7, but I must explore the sinatra package first, which is
not in EPEL7.
> ## 2.
>
> > %files
> > ...
> > %exclude %{gem_instdir}/%{gem_name}.gemspec
> > %exclude %{gem_instdir}/Rakefile
> > %exclude %{gem_instdir}/VERSION
>
> In my style, I prefer those is included to %files doc section (doc-rpm).
>
> My style is
> - *. gem_cache was excluded.
> - minimam files to run are included to %files.
> - Other text files are included to %files doc.
> because I like kind of same style with output of gem2rpm.
>
> However I can agree with you style too, as it is gray area.
>
> I want to respect your idea as much as possible if we have different style
> and it is not violation for the Guideline.
>
Thanks. I don't have strong preferences here and to be close to gem2rpm means
to be more consistent with other packages. Updated.
>
> ## 3.
>
> > [?]: Package should compile and build into binary rpms on all supported
> > architectures.
>
> Could you show me URL of Koji scratch build?
>
The new koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=15203098
Updated version:
Spec URL:
http://scientific.zcu.cz/fedora/rubygem-sinatra-cross_origin-0.3.2-2/rubygem-sinatra-cross_origin.spec
SRPM URL:
http://scientific.zcu.cz/fedora/rubygem-sinatra-cross_origin-0.3.2-2/rubygem-sinatra-cross_origin-0.3.2-2.fc26.src.rpm
%changelog
* Wed Aug 10 2016 František Dvořák <val...@civ.zcu.cz> - 0.3.2-2
- Update files section
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
