https://bugzilla.redhat.com/show_bug.cgi?id=1335901

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
I'd suggest:
%global _description \
This package provides a dispatcher for ripozo so that you can integrate ripozo
\
with Flask. As with all dispatchers it is simply for getting the request      
\
arguments and appropriately routing them to the various resources for handling.

%description %_description
%description -n python2-%{pypi_name} %_description
etc.

You don't need to remove .egg-info, this guideline has been rescinded.

cd docs/; make … → make -C docs …
or even just "sphinx-build-3 docs docs/build"

+ package name is OK
+ license is acceptable (GPLv2+)
? license is specified correctly (see below)
+ latest version is packaged
+ modern python packaging template is used
+ %python_provide macro is used
+ P/R/BR look correct
+ no scriptlets necessary
+ %check is present

Why GPLv2+ as opposed to GPLv2? I don't see "or any later version" anywhere.

fedora-review says:
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 1351680 bytes in 74 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to