https://bugzilla.redhat.com/show_bug.cgi?id=1363825

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Jitka Plesnikova <[email protected]> ---
> FIX: Please add missing build requires
>   - make (spec file, lines 45, 49, 55)
>   - findutils (spec file, line 50) - in case you do not remove the command
>   - perl(Carp) - lib/LWP/UserAgent/DNS/Hosts.pm:6
>   - perl(strict)
>   - perl(warnings)
Fixed

> FIX: Remove all the bundled Module::Install files from ./inc, build-require
>   `perl(inc::Module::Install)' and other needed modules from Module::Install
>   namespace (locate functions called from Makefile.PL). Or declare all
>   build-time dependencies for the bundled Module::Install modules.
FIX: There are missing two build requires
  perl(Module::Install::Metadata) - name, license, all_from, tests, ...
  perl(Module::Install::WriteAll) - WriteAll


> 
> TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
Fixed.


Please add two missing build-requires.

Otherwise package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to