https://bugzilla.redhat.com/show_bug.cgi?id=1362130
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
The Spec URL doesn't seem to work for me, I'm using
http://copr-dist-git.fedorainfracloud.org/cgit/samtoday/olpcau-abc123-fonts/olpcau-abc123-fonts.git/commit/?h=f24
Summary should not repeat the package name. It also doesn't need the leading
article (it looks better in listing if there's no article, since otherwise
almost everything would start with "A").
Group: User Interface/X
→ not used
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]
I don't think you have to copy sources in %prep. This breaks 'fedpkg local'
builds too.
appstream-util validate-relax --nonet should be added in %check:
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage.
You should also run full validation locally with "validate" and fix issues:
olpcau-abc123.metainfo.xml: FAILED:
• style-invalid : <summary> requires sentence case [abc123, a typeface
developed for literacy]
Validation of files failed
Package looks good.
--
I can sponsor you into the packager group. Apart from fixing the few issues
pointed out above, I would like you to do two or three reviews of other
packages (https://fedoraproject.org/PackageReviewStatus/NEW.html is a good
start) and to be familiar with mock, fedora-review, etc. There's a bunch of
fonts packages waiting for review, so you might want to take those (or not,
whatever you prefer). Until you're a packager, you cannot formally approve a
package, so please don't assign the review to yourself, just paste whatever
comments you have. If nobody beats you to it, you will be able to formally
approve those packages after you become packager. If you have any questions,
feel free to mail me, or ping on IRC (I'm "zbyszek" everywhere).
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
