https://bugzilla.redhat.com/show_bug.cgi?id=1276624

Raphael Groner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #12 from Raphael Groner <[email protected]> ---
APPROVED

Some advice/comments:

- Most of the java source files are without any license header to let our
licensecheck script fail. Please poke upstream and ask to add everywhere the
Apache header.

- My recommendation goes to use the same names for subpackages as the included
pom files are named. E.g.:
  %package jersey-jaxrs (better: %package -n swagger-jersey-jaxrs)
  result: swagger-core-jersey-jaxrs (better: swagger-jersey-jaxrs)
  /usr/share/maven-poms/swagger-core/swagger-jersey-jaxrs.pom
  swagger-core/modules/swagger-jersey-jaxrs/pom.xml

  See https://fedoraproject.org/wiki/Packaging:Java#Filenames

- There's a new version 1.5.9 at upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to