https://bugzilla.redhat.com/show_bug.cgi?id=1366881



--- Comment #2 from Luya Tshimbalanga <l...@fedoraproject.org> ---
(In reply to Igor Gnatenko from comment #1)
> Source0:
> https://github.com/ispc/ispc/archive/v%{version}/%{name}-%{version}.tar.gz

Thanks. That line is updated.

> 
> > install -m 755 -d %{buildroot}/%{_bindir}
> > cp -p %{name} %{buildroot}/%{_bindir}
> install -Dpm0755 %{name} %{buildroot}%{_bindir}/%{name}

Fixed and noted.


> > BuildRequires:      flex-devel 
> > https://codeload.github.com/ispc/ispc/tar.gz/v1.9.1
> that something strange
Oops!That was an oversight where accidentally pressed middle button mouse. The
url is now removed.


> > BuildRequires:      bison-devel
> I don't think you really need devel subpkg of bison and flex, I think main
> pkg should be enough
Devel subpkg replaced by their main packages.


> * Missing BuildRequires: gcc-c++
> * Missing BuildRequires: make
> * CFLAGS and LDFLAGS are not enforced
> -> I think %make_build OPT="%{optflags}" LDFLAGS="%{__global_ldflags}"
> should fix problem
%{optflag} part failed to build so I only use LDFLAGS. Missing BuildRequires
gcc-c++ and make added.

Here is the updated
Spec URL: https://luya.fedorapeople.org/packages/SPECS/ispc.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/ispc-1.9.1-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to