https://bugzilla.redhat.com/show_bug.cgi?id=1366878

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #3 from Igor Gnatenko <[email protected]> ---
> # python2 macros needed for EPEL7
> %{!?__python2: %global __python2 /usr/bin/python2} 
> %{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from 
> distutils.sysconfig import get_python_lib; print(get_python_lib())")} 
> %{!?py2_build: %global py2_build %{expand: CFLAGS="%{optflags}" %{__python2} 
> setup.py %{?py_setup_args} build --executable="%{__python2} -s"}}
> %{!?py2_install: %global py2_install %{expand: CFLAGS="%{optflags}" 
> %{__python2} setup.py %{?py_setup_args} install -O1 --skip-build --root 
> %{buildroot}}} 
all those macros are in EPEL7.

> %if 0%{?fedora} > 12 || 0%{?rhel} > 7
> %global with_python3 1
> %endif
%if 0%{?rhel} && 0%{?rhel} <= 7
%bcond_with python3
%else
%bcond_without python3
%endif

And replace 0%{?with_python3} with %{with python3}

> %global sum Python attributes without boilerplate
Define it in Summary tag and then use as %{summary}

> I think the "too generic" version is simpler, more obvious, doesn't cause 
> problems, and is compliant with the packaging guidelines.
for example, if upstream will start (e.g. by accident) some another module you
will not notice which will cause problems. But many packages do this, so it's
only my preference.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to