https://bugzilla.redhat.com/show_bug.cgi?id=1367825



--- Comment #2 from Neal Gompa <ngomp...@gmail.com> ---
A few things I see stand out:

* Presets are supposed to be centrally managed in Fedora. Please remove the
preset from snapd and file a bug against fedora-release to add the snapd
preset. This is per Fedora policy:
https://fedoraproject.org/wiki/Packaging:DefaultServices

* If you require specific kernel modules, please use their kmod provides. For
example, for squashfs, require "kmod(squashfs.ko)" instead of kernel-modules.

* Shouldn't modprobe be done before snapd is started? My understanding is that
snapd itself triggers the mounts of snaps, so modprobe should probably occur as
an ExecStartPre for snapd.

* I'm not sure it's a good idea to go and torch user data in the event snapd is
uninstalled. Can snapd be (theoretically) uninstalled and then installed later
and use the snaps/configs that already exist? If so, it *definitely* makes no
sense to purge everything like that.

There may be more, but those stand out at the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to