https://bugzilla.redhat.com/show_bug.cgi?id=1082825
--- Comment #8 from Dominik 'Rathann' Mierzejewski <domi...@greysector.net> --- (In reply to Ben Rosser from comment #6) > Issues > ====== > > * Version 1.3.1 seems to be available: > https://addons.mozilla.org/en-US/firefox/addon/lightbeam/; can you update > the package, and I'll re-review? Done. > * > https://fedoraproject.org/wiki/User:Kalev/ > MozillaExtensionsDraft#Sample_Spec_File seems to sugggest that XPIs should > be unpacked? I'm assuming that's no longer the case because of extension > signing? That's correct. > * This is very minor, but rpmlint is unhappy that your bundled font provides > are not versioned. The versioning information can be acquired by unzipping > the XPI and running ttname -a over the font files. It'd probably be nice to > include that information, though I wouldn't consider it a blocker for review. Done. Spec URL: http://rathann.fedorapeople.org/review/mozilla-lightbeam/mozilla-lightbeam.spec SRPM URL: http://rathann.fedorapeople.org/review/mozilla-lightbeam/mozilla-lightbeam-1.3.1-1.fc24.src.rpm * Fri Aug 19 2016 Dominik 'Rathann' Mierzejewski <r...@greysector.net> - 1.3.1-1 - update to 1.3.1 - added versions to bundled font Provides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
