https://bugzilla.redhat.com/show_bug.cgi?id=1368848

gil cattaneo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from gil cattaneo <[email protected]> ---

Issues:
=======
- Package contains Requires: ruby(release).


[!]: Gem package should exclude cached Gem.
[!]: Test suite of the library should be run.
[!]: Specfile should use macros from rubygem-devel package.
     Note: The specfile doesn't use these macros: %{gem_libdir}, %exclude
     %{gem_cache}

NON blocking issues:
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "Unknown or generated". 23 files have
     unknown license. Detailed output of licensecheck in /home/gil/1368848
     -rubygem-mercenary/licensecheck.txt

 Source files without license headers:
    mercenary-0.3.6/examples/help_dialogue.rb
    mercenary-0.3.6/examples/logging.rb
    mercenary-0.3.6/examples/trace.rb
    mercenary-0.3.6/lib/mercenary.rb
    mercenary-0.3.6/lib/mercenary/command.rb
    mercenary-0.3.6/lib/mercenary/option.rb
    mercenary-0.3.6/lib/mercenary/presenter.rb
    mercenary-0.3.6/lib/mercenary/program.rb
    mercenary-0.3.6/lib/mercenary/version.rb
    mercenary-0.3.6/script/bootstrap
    mercenary-0.3.6/script/cibuild
    mercenary-0.3.6/script/console
    mercenary-0.3.6/script/examples
    mercenary-0.3.6/spec/command_spec.rb
    mercenary-0.3.6/spec/option_spec.rb
    mercenary-0.3.6/spec/presenter_spec.rb
    mercenary-0.3.6/spec/program_spec.rb
    mercenary-0.3.6/spec/spec_helper.rb
 Please, report to upstream

[!]: License file installed when any subpackage combination is installed.

  Please, add also License file in doc sub package

Please fix before import
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]

Reply via email to