https://bugzilla.redhat.com/show_bug.cgi?id=1348202
Vít Ondruch <vondr...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vondr...@redhat.com
--- Comment #7 from Vít Ondruch <vondr...@redhat.com> ---
I have a few comments.
* The test suite is not executed
- It is always good idea to execute the test suite to make sure the package
works. There is test suite available in upstream repository, so it should
not be a problem.
* Please remove the binary extension from the source tree
- Please see [1] how to do it and for the link to associated BZ with
reasoning.
* License
- The license field does not contain valid Fedora identifier. Please see [2]
and pick the correct one (likely LGPLv2?)
[1]
http://pkgs.fedoraproject.org/cgit/rpms/rubygem-sqlite3.git/tree/rubygem-sqlite3.spec#n49
[2] https://fedoraproject.org/wiki/Licensing:Main#Software_License_List
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
