https://bugzilla.redhat.com/show_bug.cgi?id=1327635
--- Comment #4 from Javier Peña <[email protected]> --- Hi Marcos, Sorry for the delayed review. I have some comments about the spec: - We have not started creating Python3 subpackages for services yet. If Congress is Python3-compatible, I think it's ok to keep the python3 subpkg in the spec file, but it's not going to be built on CentOS. - The main package (openstack-congress) should require python-congress, otherwise we'll have to install both manually. - Please move the python-* requires from the main package to the python2-congress subpackage. - Some packages (python-oslo-config, python-glanceclient, python-novaclient, python-keystoneclient) have an Epoch, please add it to the version requirement. - You're missing the %post, %preun and %postun sections for the services. You can use https://github.com/openstack-packages/openstack-example-spec/blob/master/openstack-example.spec#L147-L154 as an example. - You can use %py2_build, %py2_install and their py3 equivalents instead of a longer command line. Also, I guess the spec will have to be updated for the Newton release of Congress. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
