https://bugzilla.redhat.com/show_bug.cgi?id=1372403
--- Comment #3 from Christoph Junghans <[email protected]> --- (In reply to Igor Gnatenko from comment #1) > > BuildRoot: %{_tmppath}/%{name}-%{version}-build > not needed Done > > > %global debug_package %{nil} > BuildArch: noarch Was already there! > > > Group: Development/Libraries/C and C++ > not needed Done > > > License: BSD-3-Clause > License: BSD Done > > > sed -i 's/-Werror//' CMakeLists.txt > bad idea, better to fix real errors ;) was report https://github.com/USCiLab/cereal/pull/337 Putting -Werror in by default is very bad. Nobody knows what warning future compilers will warn about! > > > %doc LICENSE > %license LICENSE Done > > > %{_includedir}/cereal > %{_includedir}/%{name}/ Done > > > %{_datadir}/cmake/cereal > %dir %{_datadir}/cmake > %{_datadir}/cmake/%{name}/ Done > > > cd %{_target_platform} > pushd %{_target_platform} Done > > > make %{?_smp_mflags} > %make_build -C %{_target_platform} Done > > > make -C %{_target_platform} install DESTDIR=%{buildroot} > %make_install -C %{_target_platform} Done (In reply to Igor Gnatenko from comment #2) > > Summary: Development headers and libraries for cereal library > Summary: Development files for %{name} Done > > > #test_portable_binary_archive is broken > it's better to also include link to upstream bugreport. Already reported https://github.com/USCiLab/cereal/issues/338 New SRPM URL: https://raw.githubusercontent.com/junghans/fedora-review/master/cereal/cereal-1.2.1-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list [email protected] https://lists.fedoraproject.org/admin/lists/[email protected]
