https://bugzilla.redhat.com/show_bug.cgi?id=1372670

Igor Gnatenko <ignate...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #1 from Igor Gnatenko <ignate...@redhat.com> ---
> Group:                System Environment/Kernel
not needed

> License:      LGPLv2
LGPLv2+ actually

> # "make archive" from git checkout of tag %{version} or
> # 
> https://gitlab.com/pmatilai/driverctl/repository/archive.tar.gz?ref=%{version}
> Source0:      %{name}-%{version}.tar.gz
Source0:
%{url}/repository/archive.tar.gz?ref=%{version}#/%{name}-%{version}.tar.gz

> Requires(post,postun):        systemd
%{?systemd_requires}

> make install DESTDIR=%{buildroot}
%make_install

> /usr/lib/udev/vfio_name
Can you file a bug against systemd to add macro %{_udevdir}?

> %{_sysconfdir}/bash_completion.d/driverctl-bash-completion.sh
1. it should go to %{_datadir}/bash-completion/
2. directory is not owned

* Description should end with "."
* install is invocated without "-p", so fix it in upstream as well ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

Reply via email to