https://bugzilla.redhat.com/show_bug.cgi?id=1344276
--- Comment #2 from Parag AN(पराग) <panem...@gmail.com> --- Suggestions: As per current packaging guidelines given on https://fedoraproject.org/wiki/Packaging:Guidelines 1) use %global instead of %define, See https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define 2) In %install, following is now optional and should be removed rm -rf %{buildroot} as per https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections 3) Group and BuildRoot tag are not needed now, remove them. 4) Good to write every Require: per line 5) Why every package in Requires: need hard versioned requirement? I think whatever packages are in Fedora should satisfy the requirements and make this package run without any issues. Onlyif it needs some different version then that issue need to be fixed like some package need higher version and if its not yet in Fedora then that package should be updated to that higher version thus no need to write explicit versions 6) You need to go through https://fedoraproject.org/wiki/Packaging:Python which can tell you we now use explicitly "python2" wherever you have used "python" 7) we don't need now %clean section, remove it 8) You may write your spec accordingly python packaging guidelines. 9) I can't find the 2.1.0 tarball on the given source location, fix this Submit new SPEC and SRPM by fixing above issues and adding new changelog entry. Every time you make some change in SPEC, you need to update the release tag and add changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
