https://bugzilla.redhat.com/show_bug.cgi?id=1374024
--- Comment #8 from Parag AN(पराग) <panem...@gmail.com> ---
1) The keyword here "Upstream" is not correct for this bugzilla, hence I
removed it.
2) I missed to ask do you want to add this package to epel7. If no them remove
all if...else added in spec file which may look almost same as by running
"pyp2rpm plotcat".
But if you want to add it to epel7 then just need to move following BR: inside
python3-plotcat package.
BuildRequires: python3-setuptools
BuildRequires: python3-devel
3) The pyp2rpm is adding the BuildRequires: python-setuptools which should have
been python2-setuptools for Fedora specific builds,but again if you want to add
this package to epel7 then keep BR: python-setuptools else change it to BR:
python2-setuptools.
4) symlink is not needed for this package so it can be removed. Again it looks
its added by the usage of pyp2rpm. Remove following lines
-------------------------------------------------------------------------
cp %{buildroot}/%{_bindir}/live_plot.py %{buildroot}/%{_bindir}/live_plot.py-3
ln -sf %{_bindir}/live_plot.py-3
%{buildroot}/%{_bindir}/live_plot.py-%{python3_version}
cp %{buildroot}/%{_bindir}/live_plot.py %{buildroot}/%{_bindir}/live_plot.py-2
ln -sf %{_bindir}/live_plot.py-2
%{buildroot}/%{_bindir}/live_plot.py-%{python2_version}
---------------------------------------------------------------------------
and then from the %files section as well. Just install live_plot.py file.
But then you should be having properly set python shebang in live_plot.py file.
Hence, change in you spec file
sed -i -e '/^#!\//, 1d' *.py
to
sed -i -e '/^#!\//, 1d' plotcat/*.py
5) And yes add the trailing "/" as suggested by Igor in above comment.
6) Indeed after looking into LICENSE file and source files, the license is
"GPLv3+" not just "GPLv3" because there is a "or later version" clause in
LICENSE file.
Provide updated SPEC and SRPM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
