--- Comment #1 from Ben Rosser <> ---
So, first pass looks relatively sane, except as per the newer Python guidelines
you should use the following macros in %build and %install:

%{__python2} build -> %py2_build
%{__python2} install --skip-build --root %{buildroot} -> %py2_install


It would also be good to use "python2-*" to refer to your Requires and
BuildRequires where possible.

Otherwise I didn't find any blockers, so if you can modernize the Python macros
I'll go ahead with a full review.

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to

Reply via email to