https://bugzilla.redhat.com/show_bug.cgi?id=1357064

Raphael Groner <projects...@smart.ms> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Alias|lumina-desktop              |



--- Comment #28 from Raphael Groner <projects...@smart.ms> ---

- You should document the reason for ExcludeArch in the spec file:
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures

Dropped the ExcludeArch line.

- Try adding -Wl,--as-needed to LDFLAGS to fix unused-direct-shlib-dependency
warnings

Done.

- The scriptlets page seems pretty insistent on not using certain certain
scriptlets in F24+ (aka "This scriptlet SHOULD NOT be used in Fedora 24 or
later."):
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging

As I plan to build packages for EPEL7, I keep the scriptlets.

- Large data in arch-ed rpms (Arch-ed rpms have a total of 3348480 bytes in
/usr/share). I suppose this is okay unless you want to split out the langpacks.

In my opinion, it's better to split subpackages for the individiual
applications instead incl. their correspondig translations. It's too
complicated to manage 67 languages in their own langpacks for each application.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to