https://bugzilla.redhat.com/show_bug.cgi?id=1380140
--- Comment #2 from gil cattaneo <punto...@libero.it> --- (In reply to Mukundan Ragavan from comment #1) > only two (relatively, minor) items - > > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > [ ] = Manual review needed > > > > ===== MUST items ===== > > Generic: > [x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Apache (v2.0)", "Unknown or generated". 139 files have unknown > license. Detailed output of licensecheck in > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language- > detector/licensecheck.txt > > ---> Large number of files have no license header. Please request upstream > to add license headers. Reported @ https://github.com/optimaize/language-detector/issues/67 > [?]: Package is named according to the Package Naming Guidelines. > > ---> Shouldn't this be named java-language-detector? No, unless there is already a package with this name > Diff spec file in url and in SRPM > --------------------------------- > --- > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language-detector/srpm/ > language-detector.spec 2016-09-30 20:21:14.151983090 -0400 > +++ > /home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1380140-language-detector/srpm- > unpacked/language-detector.spec 2016-09-28 14:08:22.000000000 -0400 > @@ -18,10 +18,8 @@ > BuildRequires: mvn(org.slf4j:slf4j-api) > > -# This is a fork from https://code.google.com/p/lang-guess/ (forked on > 2014-02-27) which itself is a fork > -# of the original project https://code.google.com/p/language-detection/ > with improvements > # Modified version of com.cybozu.labs:langdetect > # ./src/main/java/be/frma/langguess/GenProfile.java > # ./src/main/java/com/cybozu/labs/langdetect > -Provides: bundled(langdetect) = 1.1-20120112 > +Provides: bundled(langdetect) = 1.1 > > BuildArch: noarch > > > ---> please provide an updated spec and srpm Done Spec URL: https://gil.fedorapeople.org/language-detector.spec SRPM URL: https://gil.fedorapeople.org/language-detector-0.5-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
