https://bugzilla.redhat.com/show_bug.cgi?id=1355592



--- Comment #6 from Matthew Garrett <mj...@srcf.ucam.org> ---
Broadly speaking, this seems fine, but one significant issue: the library
package is shipping libvmi-0.11.so and libvmi.so. This seems wrong. If there's
an expectation that multiple versions of the libvmi development environment
should be parallel-installable, we should have libvmi-0.11.so.something in the
main package and libvmi-0.11.so in the -devel package. If not, we should have
libvmi.so.11 (or some other versioning) in the main package and libvmi.so in
the -devel package. Raw .so files should not be in the main libvmi package.
This is probably something that needs to be discussed with upstream - it's
easier if we solve library versioning issues there.

There's also the general concern over shared libraries calling exit(), but I
think in this case it's reasonable (it's only in the safe_malloc() function).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to