https://bugzilla.redhat.com/show_bug.cgi?id=1346060

Julien Enselme <juj...@jujens.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #2 from Julien Enselme <juj...@jujens.eu> ---
Some remarks before the review:

- Please add the COPYING file with the %license macro.
- From what I understand from the python guidelines,
(https://fedoraproject.org/wiki/Packaging:Python) the RPM must be named
python3-pintail-asciidoc (the SRPM can still be named python-pintail-asciidoc)
and use the %python_provide macro to be future ready.
- The tests are failing in mock with "ImportError: No module named
'pintail.site'" I guess you are missing a BR.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to