https://bugzilla.redhat.com/show_bug.cgi?id=1381087

Julien Enselme <juj...@jujens.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Julien Enselme <juj...@jujens.eu> ---
> There several bugs upstream about failing tests. I have enabled tests but the 
> build will not fail on tests failing. Not all tests seem to be installed, so 
> I'm running the tests directly in the source code

I didn't know that. Tests are a should items, and if you know they are
unreliable, you can completely remove the %check section. An alternative could
be to skip only the tests that causes problem (but it may not be possible or
require lots of work).

You now have rpmlint warnings about macro in comments. You can either remove
the line or use double % to avoid them. An alternative way to going to the
buildroot is to set PYTHONPATH to the current working directory.

Anyway, it looks good. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to