https://bugzilla.redhat.com/show_bug.cgi?id=1376848
Björn "besser82" Esser <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] Flags| |fedora-review? --- Comment #2 from Björn "besser82" Esser <[email protected]> --- Taken! =) *** First look at spec-file: > Source0: %name-%version.tar.gz This tarball comes from github? Please use github-style source urls: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services > Requires(post): systemd > Requires(preun): systemd > Requires(postun): systemd > > … snip … > > %post > %systemd_post %name.service > > %preun > %systemd_preun %name.service Please use proper macros for this: https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd > %prep > %setup -q Please use new `%autosetup` macro instead of `%setup -q`. > %build > autoreconf -if > %configure > make Please use `%make_build`-macro instead of plain `make`. > %files > %doc COPYING Please package license-files as `%license` instead of `%doc`. The soure-tarball contains an AUTHORS-file, which is part of the license… > %{_libdir}/%name/modules/*.so This way the built rpm does not properly own the directories below %{_libdir}. See: https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership Please fix those directly obvious issues, properly bump revision and I'll take a detailed review of the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
