https://bugzilla.redhat.com/show_bug.cgi?id=1382926
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppi...@redhat.com> ---
Spec file changes:
--- perl-HTTP-MultiPartParser.spec.old 2016-10-08 13:44:41.000000000 +0200
+++ perl-HTTP-MultiPartParser.spec 2016-10-26 19:25:39.000000000 +0200
@@ -1,6 +1,6 @@
Name: perl-HTTP-MultiPartParser
Version: 0.01
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: HTTP MultiPart Parser
License: GPL+ or Artistic
Group: Development/Libraries
@@ -10,14 +10,28 @@
BuildArch: noarch
BuildRequires: perl-generators
BuildRequires: perl >= 1:5.8.1
+
BuildRequires: perl(Carp)
+BuildRequires: perl(Cwd)
+BuildRequires: perl(Data::Dumper)
+BuildRequires: perl(Exporter)
BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(FindBin)
+BuildRequires: perl(IO::File)
BuildRequires: perl(Scalar::Util)
-BuildRequires: perl(Test::Deep)
BuildRequires: perl(Test::More) >= 0.88
+BuildRequires: perl(Test::Deep)
+
+BuildRequires: perl(lib)
BuildRequires: perl(strict)
+BuildRequires: perl(vars)
BuildRequires: perl(warnings)
+BuildRequires: perl(inc::Module::Install)
+BuildRequires: perl(Module::Install::ReadmeFromPod)
+
+BuildRequires: %{__make}
+
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%description
@@ -26,24 +40,28 @@
%prep
%setup -q -n HTTP-MultiPartParser-%{version}
+%{__rm} -rf inc
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1
-make %{?_smp_mflags}
+%{__make} %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
%{_fixperms} $RPM_BUILD_ROOT/*
%check
-make test
+%{__make} test
%files
-%doc Changes README
+%doc Changes README eg/
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Wed Oct 26 2016 Ralf Corsépius <corse...@fedoraproject.org> - 0.01-2
+- Reflect feedback from review.
+
* Sat Oct 08 2016 Ralf Corsépius <corse...@fedoraproject.org> - 0.01-1
- Initial Fedora package.
> FIX: Build-requires `make' (perl-HTTP-MultiPartParser.spec:32).
-make %{?_smp_mflags}
+%{__make} %{?_smp_mflags}
Now when you call macro instead of the command, I think is a problem of the rpm
now.
> FIX: Build-require `perl(Cwd)' (t/030_basic.t:11).
+BuildRequires: perl(Cwd)
Ok.
> FIX: Build-require `perl(Data::Dumper)' (t/lib/PAML.pm:8).
+BuildRequires: perl(Data::Dumper)
Ok.
> FIX: Build-require `perl(Exporter)' (t/lib/PAML.pm:17).
+BuildRequires: perl(Exporter)
Ok.
> FIX: Build-require `perl(FindBin)' (t/030_basic.t:6).
+BuildRequires: perl(FindBin)
Ok.
> FIX: Build-require `perl(IO::File)' (t/lib/PAML.pm:9).
+BuildRequires: perl(IO::File)
Ok.
> FIX: Build-require `perl(lib)' (t/030_basic.t:7).
+BuildRequires: perl(lib)
Ok.
> FIX: Build-require `perl(vars)' (t/035_headers.t:28).
+BuildRequires: perl(vars)
Ok.
> FIX: Either unbundle the ./inc files and build-require the Module::Install*
> modules whose functions are called from Makefile.PL or build-require
> dependencies of the bundled code (`perl(File::Find)' in
> inc/Module/Install.pm:23, `perl(File::Path)' im inc/Module/Install.pm:24
> etc.).
+BuildRequires: perl(inc::Module::Install)
+BuildRequires: perl(Module::Install::ReadmeFromPod)
[...]
+%{__rm} -rf inc
TODO: I recommend to build-require these modules in addition:
perl(Module::Install::Metadata) (Makefile.PL:5)
perl(Module::Install::WriteAll) (Makefile.PL:17)
> TODO: Package eg/example.pl as a documentation.
-%doc Changes README
+%doc Changes README eg/
Ok.
$ rpmlint perl-HTTP-MultiPartParser.spec
../SRPMS/perl-HTTP-MultiPartParser-0.01-2.fc26.src.rpm
../RPMS/noarch/perl-HTTP-MultiPartParser-0.01-2.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Package build in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=16220702). Ok.
Please consider fixing the `TODO' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
