https://bugzilla.redhat.com/show_bug.cgi?id=1389016
--- Comment #17 from Dave Love <d.l...@liverpool.ac.uk> --- (In reply to Hans Pabst from comment #15) > (3) OMP build key is not specified -> similar to #1 > I recommend to stay with #3. Thanks -- I'd meant to change that. > Other comments about the build specification: > - STATIC=0: that's fine if you want shared libraries. Btw, you can build > static libraries in addition if needed. They're normally omitted in Fedora. > - PREFETCH=1: superfluous, it's the default anyways (CPUID-based prefetch > strategy). Thanks. I thought it was documented as building a separate interface, but I hadn't checked. > - SYM=1: non-default but just fine (if symbols are needed/policy). It's needed for the debuginfo package, i.e. what you install to use gdb. > One more comment regarding the package warnings: .make files are indeed > empty, those are build artifacts and do not need to be packaged. Thanks. > The > spelling of "coprocessor" (as opposed to co-processor) is intentionally wrt > to KNC. Regarding the "spurious-executable-perm", i may rename these scripts > to .sh if that helps (though this sample needs to be scrubbed a bit anyways > ;-). Most of what rpmlint reports isn't actual speling erors and can be ignored. (It does grate if I have to use US/Cambridge English per policy.) I don't think there's anything particularly wrong with the executable scripts. I think the complaint is about them not starting with #! but the ones I checked don't actually need to. (There's typically rpmlint noise about the contents of doc/example packages.) Thanks for the expert comments generally. One question: is it a bug that "make install" actually builds things after the build stage has run? Ideally it wouldn't, but I didn't think it was worth worrying about. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
