https://bugzilla.redhat.com/show_bug.cgi?id=1388294
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review+
--- Comment #17 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
The change to support python versions is impressive! I wish everybody would
handle requests for python3 support so incredibly fast...
About runtests.sh: I don't think run_tests_fedora() function is worth the
trouble. I certainly does the job, so if you want it this way, it's acceptable,
but it a) makes things less transparent, b) hard-codes python versions. For
Fedora, for the foreseeable future, we'll be building against python2 and
python3, but for example for EPEL, we build against python%{python2_version},
python%{python3_version}, which currently are python2.7 and python3.4, but this
might change. So if you wanted to build an EPEL branch, you'd have to fight
with runtests.sh to specify python versions. Also, it makes hard to make the
build for a certain version conditional.
Without further ado:
- latest version
- package name is OK
- license is acceptable (ASL2)
- license is specified correctly
- macros are used where they should
- %check is present and passes
- provides/requires look OK
- no scriptlets present or necessary
Package is APPROVED. (You will not be able to request formal creation of the
package until after you are added to the packagers group, i.e. until the other
half of comment #c6 is finished.)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
