https://bugzilla.redhat.com/show_bug.cgi?id=1387873

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #5 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
The upstream decision to move to python3 only is quite unfortunate. But what's
done that's done. Adding a compat python2 package is reasonable.

The name is OK, it should be lowercase, in line with current guidelines.

I think you should:
- add a fat warning in the %description that this is a compat package and
should not be used for new stuff

- drop the documentation parts from the package: documentation is useful for
new stuff, and nobody should be using that
- replace the useless macros like %__sed with normal calls [see
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros].
- use %py2_build and %py2_install

The first point is "user visible", the remaining three are just cleanup, so
just a suggestion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to