https://bugzilla.redhat.com/show_bug.cgi?id=1279112
František Dvořák <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] --- Comment #11 from František Dvořák <[email protected]> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #10) > Please remove the definition of %version: just put the version in Version, > rpm defines the macro %version automatically. > Right, it will be better to not override %{version} macro. Updated. > All %descriptions have an empty line at the beggining, it should be removed. > Nice catch, updated. > I'd change: > for type in float double int16 int32; do > mkdir build_${type} > pushd build_${type} > CFLAGS="%{optflags}" LDFLAGS="%{?__global_ldflags}" \ > DATATYPE=${type} \ > make %{?_smp_mflags} -f %{SOURCE1} libdir=%{_libdir} srcdir=.. > popd > done > → > for type in float double int16 int32; do > mkdir build_${type} > %make_build -f %{SOURCE1} libdir=%{_libdir} srcdir=.. \ > CFLAGS="%{optflags}" LDFLAGS="%{?__global_ldflags}" \ > DATATYPE=${type} > done > (only because it's simpler...) > There is difference between: make CFLAGS=... and: CFLAGS=... make I would rather not change it. It's only cosmetic hint anyway, right? > %{!?_licensedir:%global license %doc} > is not necessary, %license is now defined in all Fedora and EPEL versions. > OK, removed. > Please add a comment that fftw is only used for benchmarking during build > (FFTW is GPLv2). > Comment added. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
