https://bugzilla.redhat.com/show_bug.cgi?id=1388945
Sam P. <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Sam P. <[email protected]> --- Hello! I'm new to the fedora packaging thing, and I am going to try to review this package. It compiles on my computer, there are no errors in rpmlint and the package works once I installed it. It is a really slick extension as well. I was reading the spec file, and I see that the source files are manually enumerated: %{_gsextdir}/%{uuid}/metadata.json %{_gsextdir}/%{uuid}/extension.js %{_gsextdir}/%{uuid}/dbus.js %{_gsextdir}/%{uuid}/lib.js %{_gsextdir}/%{uuid}/panel.js %{_gsextdir}/%{uuid}/player.js %{_gsextdir}/%{uuid}/prefs.js %{_gsextdir}/%{uuid}/settings.js %{_gsextdir}/%{uuid}/widget.js %{_gsextdir}/%{uuid}/stylesheet.css Could you use a wildcard instead? I worry that the upstream might add new files (as developers like to do - it would be a very normal thing) and the package would ship broken. Other scripting language based packages, eg. Sugar in python [1], use wildcards for this kind of thing. [1] https://pkgs.fedoraproject.org/cgit/rpms/sugar.git/tree/sugar.spec#n219 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
