https://bugzilla.redhat.com/show_bug.cgi?id=1394962

Zbigniew Jędrzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
%description
Clevis is a framework for automated decryption.
→ great, but please provide some detail here. Automated decryption of what? Is
this another jack the ripper clone?

make %{?_smp_mflags} V=1
make %{?_smp_mflags} check
→ %make_build V=1
  %make_build check

rm -rf $RPM_BUILD_ROOT
→ please no
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

Fedora review says:
Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
- Package uses hardened build flags if required to.
  Note: suid files: clevis-luks-udisks2 and not %global _hardened_build
  See:
 
http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags

rpmlint:
clevis-udisks2.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/clevis-luks-udisks2.desktop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to