https://bugzilla.redhat.com/show_bug.cgi?id=1396331

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #1 from Igor Gnatenko <[email protected]> ---
Some issues to fix, but in general looks good.

[!]: Sources can be downloaded from URI in Source: tag
     Note: Could not download Source0:
     http://downloads.sf.net/elfio/elfio-3.2.tar.gz
     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags

elfio-devel.noarch: W: spelling-error %description -l en_US dependant ->
dependent, defendant, depend ant
elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/ChangeLog
elfio-devel.noarch: E: zero-length /usr/share/doc/elfio-devel/NEWS
elfio.src: W: spelling-error %description -l en_US dependant -> dependent,
defendant, depend ant

Missing BuildRequires: gcc-c++

make %{?_smp_mflags} -> %make_build

you could also run some "tests" in %check. Because elfdump is compiled anyway,
just run it against, let's say %{_bindir}/make.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to