https://bugzilla.redhat.com/show_bug.cgi?id=1396216

Thomas Andrejak <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Thomas Andrejak <[email protected]> ---
I'm not a packager yet, hence the review is unofficial.

- Be carefull with 80 columns, even in comments, but when you have space
(%description), use it

- On my side, http://wiki.fasterxml.com/AaltoHome is not working

- In %description javadoc, use a more interesting description (We already now
that this is a package, and this is the javadoc) or use the same description as
the main package

- Why are you doing this :
mv release-notes/asl/ASL2.0 LICENSE
mv release-notes/asl/LICENSE NOTICE

in %files you can use %licence with path

- %files javadoc : %license is only required in main package

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to