https://bugzilla.redhat.com/show_bug.cgi?id=1392950
Thomas Andrejak <thomas.andre...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |thomas.andre...@gmail.com
--- Comment #1 from Thomas Andrejak <thomas.andre...@gmail.com> ---
Hello
I'm not a packager yet, hence the review is unofficial. Also, I do not have
s390 or s390x so I can't build it but I have some comments.
- Summary:
I propose to remove "Provides a "
- Source0:
At the end, you should use %{name}-%{version}.tgz
- Patch0:
Also, use %{version}
- In %package, do not specify the group
- In %package, I think you have to add the %{?_isa} to requires
- %package static
Provides: foo-static = %{version}-%{release} <== Typo for "foo" ?
- %prep
I think you can use %autosetup
- %files doc
Is there a reason you are using a different license file than "%files"
Regards
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
