https://bugzilla.redhat.com/show_bug.cgi?id=1395804
--- Comment #5 from Fabian Affolter <[email protected]> --- (In reply to Iryna Shcherbina from comment #3) > The spec file looks good to me, but I would suggest to do another small > change. > The %description is missing one sentence comparing to the one in package > documentation and therefore seems incomplete. > Please change it to the original one: > > A simple Python module to retrieve battery information on Linux-based > operating system. No ACPI or external software is needed. Only the Linux > kernel and its /sys/class/power_supply folder. Changed > Also, could you please explain to me why you define the following: > > > %if 0%{?fedora} > > %bcond_without python3 > > %else > > %bcond_with python3 > > %endif Needed to build the package for EPEL as there is Py3. (In reply to Iryna Shcherbina from comment #4) > Another thing is that batinfo contains tests, they are just > not included into the tarball: > > https://github.com/nicolargo/batinfo/blob/master/test_batinfo.py > > You should either get the tests from github or create an issue to include > them, and run them in %check section. https://github.com/nicolargo/batinfo/issues/12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
