https://bugzilla.redhat.com/show_bug.cgi?id=1289717

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #17 from Igor Gnatenko <[email protected]> ---
* Don't build examples as you don't really package it (you can put source code
of them in -devel subpackage if it's not huge amount of data) and remove
examples subpackage
* Remove all magic numbers and if you need to exclude some test, write link to
upstream bugreport
* Own %dir %{_datadir}/cmake
* Not sure if ./viennacl/tools/sha1.hpp used during compilation, if yes, then
License should look like "MIT and ISC"
* drop bundled opencl headers and use system ones from opencl-headers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to