https://bugzilla.redhat.com/show_bug.cgi?id=1394788
--- Comment #5 from Jakub Hrozek <[email protected]> --- Some more nitpicks I noticed after reading https://fedoraproject.org/wiki/PackagingDrafts/Lua and checking other lua spec files: 1) https://fedoraproject.org/wiki/PackagingDrafts/Lua says that packages should define: Requires: lua(abi) = %{luaver} I'm not sure if this is better or worse than: Requires: lua >= %{lua_version} that you used but I think requiring the ABI version would detect ABI breaks. 2) The specfile owns a directory also owned by lua, why? %dir %{lua_libdir} didn't you only want to own: %{lua_libdir}/mpack.so ? I'm sorry I didn't notice these the first time. If these nitpicks are resolved, I will approve the package :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
