https://bugzilla.redhat.com/show_bug.cgi?id=1396232

Igor Gnatenko <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Igor Gnatenko <[email protected]> ---
* BuildRequires:    git -> BuildRequires:    git-core
git itself requires a lot of perl which you don't really need to apply patches.
* %autosetup -S git
probably you just want %autosetup -p1 to not pull git into BuildRequires
* %doc LICENSE README
LICENSE should be %license, READNE should be %doc
* Also put comment where you sent patches to upstream (or why you didn't
sent)...

Apart from that, looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to