https://bugzilla.redhat.com/show_bug.cgi?id=1398922
Yunying Sun <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Yunying Sun <[email protected]> --- An unformal review: 1. No version specified in %changelog. changelog format: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs 2. Static libraries are discouraged. Add "--disable-static" in %configure, and add -devel package where *.so could be included. Refer to: https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries https://fedoraproject.org/wiki/Packaging:Guidelines#DevelPackages 3. Missing %doc for README.md. 4. Use %{name} instead of fixed string "uftrace" would be better in spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
