https://bugzilla.redhat.com/show_bug.cgi?id=1348959



--- Comment #4 from Guido Aulisi <[email protected]> ---
This is an unofficial review (cont).
Some other comments.

Sorry for the above statement, I meant I don't know this software, so I cannot
test functionality, but only packaging.

Some missing BuidRequires

BuildRequires:  gcc
BuildRequires:  make

You could use %{make_build} macro exporting CFLAGS and LDFLAGS like this:

export CFLAGS="%{optflags} -pedantic -std=c99"
export LDFLAGS="%{__global_ldflags} -lX11 -lXrandr"
%make_build

Cheers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to