https://bugzilla.redhat.com/show_bug.cgi?id=1331449

Jonny Heggheim <jonnyheggh...@sigaint.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #2 from Jonny Heggheim <jonnyheggh...@sigaint.org> ---
Review approved!

Comments:
* Should use the lastest version

* Consider following the SourceURL package guideline for git tags
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags

* Consider deleting the bundled gradle wrapper in %prep

* Consider using %gradle_build
https://fedora-java.github.io/howto/25/index.html#gradle

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to