https://bugzilla.redhat.com/show_bug.cgi?id=1331449



--- Comment #4 from gil cattaneo <punto...@libero.it> ---
(In reply to Jonny Heggheim from comment #2)
> Review approved!
thanks!
> Comments:
> * Should use the lastest version
Done
> * Consider following the SourceURL package guideline for git tags
> https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
Used:
Source0:      
https://github.com/sgroschupf/zkclient/archive/%{version}/%{name}-%{version}.tar.gz
> * Consider deleting the bundled gradle wrapper in %prep
Already done
> * Consider using %gradle_build
> https://fedora-java.github.io/howto/25/index.html#gradle
Done

Spec URL: https://gil.fedorapeople.org/zkclient.spec
SRPM URL: https://gil.fedorapeople.org/zkclient-0.10-1.fc24.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16700694

(In reply to Jonny Heggheim from comment #3)
> Can you review bug 1399833 ?
Sure!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to