https://bugzilla.redhat.com/show_bug.cgi?id=1379830

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+



--- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
According to the guidelines, Provides: python2-pdc-updater must be added
[https://fedoraproject.org/wiki/Packaging:Python#Provides].

+ package name is OK
+ latest version
+ license is acceptable (LGPGv2+)
+ license is specified correctly
+ R/BR look correct
- Provides look OK, with one exception, see note above
+ builds and installs OK
+ no scriptlets necessary

You could replace:
%{__python2} setup.py build
with %py2_build

and
%{__python2} setup.py install -O1 --skip-build --root=%{buildroot}
with %py2_install.

Package is APPROVED, please fix up the Provides when importing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to