https://bugzilla.redhat.com/show_bug.cgi?id=1359914



--- Comment #27 from Jeremy Newton <[email protected]> ---
(In reply to MartinKG from comment #26)
> Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec
> SRPM URL:
> https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.223-1.fc25.src.
> rpm
> 
> %changelog
> * Fri Dec 09 2016 Martin Gansser <[email protected]> - 0.9.223-1
> - Update to 0.9.223
> - Add subpkg lollypop-cli

The issue of the portal dependency still exists. lollypop should require
lollypop-portal, not the other way around.

Right now portal has the following requirement:
> Requires:       %{name} = %{version}-%{release}

This should be removed and the following should be added on the base package:
> Requires:       %{name}-portal = %{version}-%{release}

This also allows a user to only install lollypop-portal, if they wish to use
the flatpak instead.

As well, is --prefix=/usr should not be used for autogen.sh. I would personally
suggestion running autogen with NOCONFIGURE set, thus to prevent configure from
running, then configure using the %configure macro.

I'm assuming something like this would work:
> pushd %{subpkg}-%{commit0}
>     NOCONFIGURE=1 ./autogen.sh
>     %configure
> popd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to