https://bugzilla.redhat.com/show_bug.cgi?id=1403417
--- Comment #2 from Michael Schwendt <bugs.mich...@gmx.net> --- $ fedora-review -b 1403417 INFO: Processing bugzilla bug: 1403417 ... INFO: Downloading .spec and .srpm files error: %changelog entries must start with * So, the fedora-review tool cannot even build this one. No %changelog section at all in the spec file? https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Then a look at the src.rpm, which contains a different spec file: -- gsequencer.spec 2016-12-09 22:08:56.000000000 +0100 +++ gsequencer.spec.ticket 2016-12-10 02:08:17.000000000 +0100 @@ -46,6 +46,7 @@ %files -n gsequencer %license COPYING +%changelog ChangeLog %{_libdir}/libags.* %{_libdir}/libags_thread.* %{_libdir}/libags_server.* That won't work. %changelog starts an own section in the spec file. It is not a macro to use for including a doc file. [...] A couple of early finds based on skimming over the package: Since you use pkg-config for detecting and using build dependencies, be aware of: https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_based_on_pkg-config There are also automatically added RPM dependencies for the pkg-config .pc file inter-dependencies. See output of "rpm -qpR gsequencer-devel-0.7.114-0.fc25.x86_64.rpm", for example. If you rely on pkg-config based dependencies, you would not need to add explicit Requires to your -devel package and maintain that list manually. > %files -n gsequencer The "-n gsequencer" is superfluous, because for the main package it defaults to %name. No need to respecify the package name. > %{_defaultdocdir}/gsequencer/ Unless your configure script explicitly uses something related to %_defaultdocdir, for brevity you may want to prefer the shorter %{_docdir} which also expands to /usr/share/doc (= %_datadir/doc). You will see documentation mention %_docdir more often than %_defaultdocdir. Currently they expand to the same, however. > %{_libdir}/libags.* > %{_libdir}/libags_thread.* > %{_libdir}/libags_server.* > %{_libdir}/libags_gui.* > %{_libdir}/libags_audio.* https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages > %{_datadir}/applications/gsequencer.desktop https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files > %{_datadir}/doc-base/gsequencer-documentation What about %_datadir/doc-base/? https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories > %{_datadir}/xml/gsequencer/ Will the %_datadkir/xml directory always be available? Or is a dependency missing? > %package -n gsequencer-devel https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package If requiring the base, there is also no need to duplicate the license in the -devel package. > %package -n gsequencer-devel-docs The guidelines recommend a -doc ending: https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > Requires: devhelp Not strictly needed for plain HTML documentation. > %{_datadir}/gtk-doc/html/* https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
