https://bugzilla.redhat.com/show_bug.cgi?id=1404012
--- Comment #3 from Ralph Bean <[email protected]> --- (In reply to Miroslav Suchý from comment #2) > Preliminary review: > * you are missing systemd snippets > https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Systemd Thanks! We can add these. > * it is shame that you start with python2 when everything is being moved to > python3 :( (but it does not block the review) Agreed. :( We started off on python3, but got blocked by the `koji` libs still being python2 only. As I understand it, there is movement on making them python3-capable upstream, so we should be able to port over sooner than later. > * there are test in tar.gz, but not used in %check. Any reason for that? Yes, I believe that some of them require network connectivity which would fail in koji. I can have a closer look and give a more thorough assessment. > * it would be nice to have man pages for /usr/bin/* tools Yes, agreed. We should add `--help` options to each of those commands and then use help2man. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
